Block remote URLs in look_at file_path#1758
Merged
code-yeongyu merged 1 commit intocode-yeongyu:devfrom Feb 13, 2026
Merged
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Simple validation addition with comprehensive tests. Regex is correct (/^https?:///i), error message is clear, tests cover http/https and case-insensitivity. No logic changes to existing code, Purel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://andhttps://URLs inlook_attool'sfile_pathparameter.pathToFileURL()instead of returning a clear error.Changes
validateArgs()inlook-at-arguments.ts— rejectsfile_pathstarting withhttp://orhttps://(case-insensitive).http://,https://, and mixed-caseHTTPS://URLs.Testing
Summary by cubic
Blocks remote HTTP/HTTPS URLs in look_at’s file_path to prevent silent mangling. Users now get a clear error and must use a local path or image_data.
Written for commit 3eb7dc7. Summary will update on new commits.